feat: presenter#7
Conversation
|
Can you rebase feat/presenter with the newest version of alex_stuff? That should get rid of most of the merge conflicts. |
Yeah i will tonight. Probably. Maybe |
…atures to device createinfo
gituser12981u2
force-pushed
the
feat/presenter
branch
from
22ddda4 to
859b2cf
Compare
…rent path than linux and windows runtimes
|
About the Apple issue with VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_1_2_FEATURES and VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VULKAN_1_3_FEATURES I talked to you about, you know the thing that was giving me a segfault, well I made a fix in the last commit and, for fun, I checked the non Apple path on my MacBook and it somehow worked. So I guess everything the chain does work and it was some other little problem with the implementation before. I don't know any more. I will just blame MoltenVK. I am making a new commit without the Apple path. |
Also update some CMake files with cmake_format formatter
…log to include patch version
…c shared ptr suggestion
gituser12981u2
force-pushed
the
feat/presenter
branch
from
ebbee87 to
e64fbbd
Compare
gituser12981u2
dismissed
their stale review
This review has been satisfied. I don't know why GitHub seems to think it has not been satisfied.
2 participants
Keeping the cmake changes in this as makes it easier to do testing,
Added vk12/vk13 switch, I am pretty sure I could've made it a template class with specialisations for each.
So feel free to rebuke me on that. I don't think it matters(?).
Also added the presenter abstraction.